Is this the best way to move player

[tschwarz]

I'm just starting out with Brutus so, I thought I would ask and make sure I'm starting on the right foot.


option explicit
'~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
' Declare your variables

dim bRunning
dim ImgShip
Dim ScrnX
Dim ScrnY
Dim MoveShipX
Dim MoveShipY
bRunning = True
MoveShipX = 0
ScrnX = 1024
ScrnY = 768

Call InitializeSettings
Call Main()

'****************************************************************************************

sub main()

do while bRunning = True

if key.pressed(vk_escape) or key.pressed(vk_windowx) = True then bRunning = False

graphics.clear

'start position
graphics.SetX ImgShip, ScrnX / 4
graphics.Sety ImgShip, ScrnY / 2
graphics.SetImage(ImgShip)

Call MoveShip

graphics.display
loop

Key.terminate
Graphics.terminate
Mouse.terminate
end sub

Sub MoveShip

if key.pressed (vk_LEFT) and graphics.GetX(ImgShip) > (graphics.GetWidth(ImgShip)/2) then ' left
moveShipX = moveShipX - 5
graphics.SetAutoMove ImgShip, moveShipX, moveShipY, 10
graphics.GetX(ImgShip)
elseif key.pressed(vk_RIGHT) and graphics.GetX(ImgShip) < ScrnX - graphics.GetWidth(ImgShip) then ' right
moveShipX = moveShipX + 5
graphics.SetAutoMove ImgShip, moveShipX, moveShipY, 10
graphics.GetX(ImgShip)
elseif key.pressed(vk_UP) and graphics.GetY(ImgShip) > graphics.GetHeight(ImgShip) then ' up
moveShipY = moveShipY - 5
graphics.SetAutoMove ImgShip, moveShipX, moveShipY, 10
graphics.GetY(ImgShip)
elseif key.pressed(vk_DOWN) and graphics.GetY(ImgShip) < ScrnY - (graphics.GetHeight(ImgShip)*2) then ' down
moveShipY = moveShipY + 5
graphics.SetAutoMove ImgShip, moveShipX, moveShipY, 10
graphics.GetY(ImgShip)
end if

End sub

Sub InitializeSettings

if (graphics.initialize(ScrnX,ScrnY,false) <> True) then exit sub 'Run full screen
Key.initialize 'Initialize Keyboard
Mouse.initialize 'Initialize Mouse
Mouse.hide

'Load Images
ImgShip = graphics.loadimage("shiptest.png") ' load the image

End sub

[u9]

There is no "best" way But anyway, try changing your main routine like this:


graphics.clear

'start position
'graphics.SetX ImgShip, ScrnX / 4
'graphics.Sety ImgShip, ScrnY / 2
graphics.SetImage(ImgShip)
Call MoveShip

graphics.SetFPS 60
graphics.display


I have commented out SetXY, because the image is positioned in the MoveShip sub-routine. The SetFPS will keep the game running at the same speed on all computers.

And here are the changes i made to the MoveShip sub-routine. I have written comments to explain what is going on:


Sub MoveShip
 
  ' Read input
  if key.pressed (vk_LEFT) then
     moveShipX = moveShipX - 0.1
  end if
  if key.pressed(vk_RIGHT) then ' right
     moveShipX = moveShipX + 0.1
  end if
  if key.pressed(vk_UP) then ' up
     moveShipY = moveShipY - 0.1
  end if
  if key.pressed(vk_DOWN) then ' down
     moveShipY = moveShipY + 0.1
  end if
 
  ' Keep ship inside screen
  if graphics.GetX(ImgShip) < 0 then
     moveShipX = 0 ' Stop it from moving...
     graphics.SetX ImgShip, 0 ' ... and put it back inside the screen
  end if
 
  if graphics.GetX(ImgShip) > ScrnX - graphics.GetWidth(ImgShip) then
     moveShipX = 0
     graphics.SetX ImgShip, ScrnX - graphics.GetWidth(ImgShip)
  end if
 
  if graphics.GetY(ImgShip) < 0 then
     moveShipY = 0
     graphics.SetY ImgShip, 0
  end if
 
  if graphics.GetY(ImgShip) > ScrnY - graphics.GetHeight(ImgShip) then
     moveShipY = 0
     graphics.SetY ImgShip, ScrnY - graphics.GetHeight(ImgShip)
  end if
 
  ' Limit the speed of the ship. Math object requires registered version of Brutus2D
  moveShipX = math.clip( moveShipX, -5, 5 )
  moveShipY = math.clip( moveShipY, -5, 5 )
 
  ' Set automatic movement of ship
  graphics.SetAutoMove ImgShip, moveShipX, moveShipY, 10
End sub


[tschwarz]

Humm, When dropping your Sub MoveShip into my code the ship does not move. I'll take some time later to go through the code more. I really appreciate your time looking at code.

Thank you

edit: just remarking out the start position code changes the way the ship moves. I thought the code just set the start position but, I guess I was wrong. Your comments will help me a lot to get a grip on how this works.